Repository navigation
make id gap a UndulatorGapMotor - #2167
Closed
Relm-Arrowny wants to merge 26 commits into
Closed
Relm-Arrowny wants to merge 26 commits into
Relm-Arrowny wants to merge 26 commits into
Conversation
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## update_id_logic_to_use_standard_movable #2167 +/- ##
========================================================================
Coverage 99.18% 99.19%
========================================================================
Files 365 364 -1
Lines 14386 14363 -23
========================================================================
- Hits 14269 14247 -22
+ Misses 117 116 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…b.com/DiamondLightSource/dodal into update_id_logic_to_use_standard_movable
* Create UndulatorAccessControl Device * Clean up imports * Add access control as dependency for test * Add doc string and improve set_ and wait func
This reverts commit 20383ba.
Base automatically changed from
update_id_logic_to_use_standard_movable
to
main
August 18, 2026 08:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored UndulatorGap to inherit directly from UndulatorGapMotor, removing the nested self.motor wrapper and simplifying signal delegation.
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}